Skip to content

fix(GrpcServlet): fix constructor modificator after PR #12333#12419

Closed
long76 wants to merge 1 commit intogrpc:masterfrom
long76:patch-1
Closed

fix(GrpcServlet): fix constructor modificator after PR #12333#12419
long76 wants to merge 1 commit intogrpc:masterfrom
long76:patch-1

Conversation

@long76
Copy link
Copy Markdown

@long76 long76 commented Oct 15, 2025 •
edited
Loading

ServletContainerInitializer allow register servlet with custom methodNameResolver but it's not asyncSupported = true.

Please backport to v1.76.x and make release v1.76.1. Thanks!

@long76 long76 mentioned this pull request Oct 15, 2025
Closed
@panchenko
Copy link
Copy Markdown
Contributor

panchenko commented Oct 15, 2025

#11825 (comment) ?

@long76
Copy link
Copy Markdown
Author

long76 commented Oct 15, 2025

#11825 (comment) ?

checking)

@long76
Copy link
Copy Markdown
Author

long76 commented Oct 15, 2025 •
edited
Loading

#11825 (comment) ?

i can't set asyncSupported = true in this way

@panchenko
Copy link
Copy Markdown
Contributor

panchenko commented Oct 15, 2025

ServletRegistration.Dynamic inherits setAsyncSupported() from base interfaces

@long76
Copy link
Copy Markdown
Author

long76 commented Oct 15, 2025 •
edited
Loading

ServletRegistration.Dynamic inherits setAsyncSupported() from base interfaces

thanks, cheking. i just use ServletRegistration type after call addServlet)

@long76
Copy link
Copy Markdown
Author

long76 commented Oct 15, 2025

yes, all ok. but need add META-INF/services/javax.servlet.ServletContainerInitializer) but if set constructor maybe all in one)

@long76 long76 closed this Oct 15, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@long76 @panchenko